[FIX]: Change URLs in npm install command#868
Merged
Conversation
…o install it from the npm package registry
…stall it from the npm package registry
There was a problem hiding this comment.
Pull request overview
Fixes the broken docs Docker image npm installs by switching invalid GitLab/GitHub “browse” URLs to installable package specs (npm registry versions for Antora packages, and proper git URLs with commit hashes for git-installed dependencies).
Changes:
- Replace non-installable Antora GitLab
/tree/<sha>/...URLs with npm registry installs for@antora/cliand@antora/site-generator. - Fix git dependency install specs by switching to
.git#<commit>format forantora-lunr-extensionandmermaid-cli.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
PRfixes the brokennpmsinstall by changing the URLs, the bug was introduced byPR#848.This fix has the shortcoming of rolling back the install commands of antora
cliand antorasite-generatorto installation from the npm package repository. The problem with these two is that they are part of a mono-repository, where a lot of packages are developed. I was unable to find a solution where we can pin the installs with a commit hash.PR #857 is a failed attempt.